fix(executor): Update proto compilation and package versions #1681
Conversation
Updates the `compile_seldon_proto` rule to place the updated protobuf in the correct location, along with correcting the package name and updating the grpc package version to work with newer versions of the proto compiler. Addresses SeldonIO#1663 Signed off by Nick Groszewski (<[email protected]>)
|
Hi @groszewn. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@cliveseldon Opened based off of our conversation in the Custom protobuf support PR |
|
/assign @cliveseldon |
|
@cliveseldon just wanted to check in and see if you had any feedback based off of Custom protobuf support PR. |
|
/ok-to-test |
|
/test integration |
|
Thank you @groszewn we'll merge this one first so the other one can go first. Looks good so we'll be able to land once the integration tests pass (excluding some flaky ones) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Mon Apr 20 13:46:21 UTC 2020 impatient try |
|
Mon Apr 20 13:46:22 UTC 2020 impatient try |
|
Mon Apr 20 13:46:26 UTC 2020 impatient try |
|
failed to trigger Pull Request pipeline
|
Updates the
compile_seldon_protorule to place the updated protobuf inthe correct location, along with correcting the package name and
updating the grpc package version to work with newer versions of the
proto compiler.
Addresses #1663
Signed off by Nick Groszewski ([email protected])